“All that and a bag of chips” is 90s slang describing something that is upmost beautiful or eye catching. It’s a superlative form of all that.
This term was used mostly in a sarcastic or satirical form. Back in the day my friends and I jokingly used the phrase when one of us got a haircut. “You think you all that and a bag of chips with that new cut!?”.